[PATCH 02/20] convert: fix leaks when resetting attributes
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 20, 2024, 14:05 UTC
- Message-ID
- <ed0f01bf92c83fb7371326bd1a59933619de2c47.1724159575.git.ps@pks.im>
- In-Reply-To
- <cover.1724159575.git.ps@pks.im>
When resetting parsed gitattributes, we free the list of convert drivers parsed from the config. We only free some of the drivers' fields though and thus have memory leaks.
Fix this by freeing all allocated convert driver fields to plug these memory leaks.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- convert.c | 3 +++ t/t4150-am.sh | 1 + 2 files changed, 4 insertions(+)
diff --git a/convert.c b/convert.c index e6184d21f26..c9a31eb4f03 100644 --- a/convert.c +++ b/convert.c @@ -1371,6 +1371,9 @@ void reset_parsed_attributes(void) for (drv = user_convert; drv; drv = next) { next = drv->next; free((void *)drv->name); + free((void *)drv->smudge); + free((void *)drv->clean); + free((void *)drv->process); free(drv); } user_convert = NULL; diff --git a/t/t4150-am.sh b/t/t4150-am.sh index 5e2b6c80eae..232e1394e8d 100755 --- a/t/t4150-am.sh +++ b/t/t4150-am.sh @@ -5,6 +5,7 @@ test_description='git am running' GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success 'setup: messages' '
-- 2.46.0.164.g477ce5ccd6.dirty