[PATCH 19/20] transport: fix leaking arguments when fetching from bundle
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 20, 2024, 14:05 UTC
- Message-ID
- <b72f7d1ee394291a018061c91222ea17a99c2e53.1724159575.git.ps@pks.im>
- In-Reply-To
- <cover.1724159575.git.ps@pks.im>
In `fetch_refs_from_bundle()` we assemble a vector of arguments to pass to `unbundle()`, but never free it. Fix this leak.
This memory leak gets hit in t5510, but fixing it isn't sufficient to make the whole test suite pass.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- transport.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/transport.c b/transport.c index f0672fdc505..da639d3bff0 100644 --- a/transport.c +++ b/transport.c @@ -189,6 +189,8 @@ static int fetch_refs_from_bundle(struct transport *transport, &extra_index_pack_args, fetch_pack_fsck_objects() ? VERIFY_BUNDLE_FSCK : 0); transport->hash_algo = data->header.hash_algo; + + strvec_clear(&extra_index_pack_args); return ret; }
-- 2.46.0.164.g477ce5ccd6.dirty