Re: [PATCH 09/11] bisect: check strbuf_getline_lf return when reading terms
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 15, 2026, 01:17 UTC
- Message-ID
- <xmqqh5m1qcfh.fsf@gitster.g>
- In-Reply-To
- <17c382fdf46eada79ce03a7604dd7e0454d8bea4.1784069325.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 19 quoted lines
> diff --git a/builtin/bisect.c b/builtin/bisect.c
> index 798e28f501..fe66d84382 100644
> --- a/builtin/bisect.c
> +++ b/builtin/bisect.c
> @@ -498,9 +498,15 @@ static int get_terms(struct bisect_terms *terms)
> }
>
> free_terms(terms);
> - strbuf_getline_lf(&str, fp);
> + if (strbuf_getline_lf(&str, fp) == EOF) {
> + res = -1;
> + goto finish;
> + }
> terms->term_bad = strbuf_detach(&str, NULL);
> - strbuf_getline_lf(&str, fp);
> + if (strbuf_getline_lf(&str, fp) == EOF) {
> + res = -1;
> + goto finish;
> + }We want to clean-up terms->term_bad when we fail to read the second line after reading the first line successfully, no?
> terms->term_good = strbuf_detach(&str, NULL); > > finish: