Re: [PATCH v3 00/12] coverity: fix unchecked returns
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 12, 2026, 17:29 UTC
- Message-ID
- <xmqq5x1fxn5u.fsf@gitster.g>
- In-Reply-To
- <pull.2179.v3.git.1786521801.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 13 quoted lines
> This is the next batch of fixes in response to issues reported by Coverity. > > Changes since v2: > > * Added a new commit to handle block-writer initialization errors (instead > of ignoring them). > * The bw->zstream attribute is now also deinitialized in the error case, as > suggested by Junio. > * The commit message of "reftable/block: check deflateInit() return value" > was rephrased to stop suggesting that silent corruption by zlib would be > possible before that patch: This turned out to be provably incorrect. > * When aborting the bisect because dup2() failed, a left-over saved_stdout > is now also cleaned up.
Everything looks sensible. I am fine with declaring victory, but does anyone want to second it?