git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 06/11] compat/pread: check initial lseek for errors

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 5, 2026, 14:29 UTC
Message-ID
<11e705f9-d64f-f8c8-3967-d3289e47eb91@gmx.de>
In-Reply-To
<alcvjynWsHZKXD84@pks.im>
Hi Patrick,
On Wed, 15 Jul 2026, Patrick Steinhardt wrote:
Show 18 quoted lines
> On Tue, Jul 14, 2026 at 10:48:39PM +0000, Johannes Schindelin via GitGitGadget wrote:
> > diff --git a/compat/pread.c b/compat/pread.c
> > index 484e6d4c71..ac7d058cb8 100644
> > --- a/compat/pread.c
> > +++ b/compat/pread.c
> > @@ -7,6 +7,8 @@ ssize_t git_pread(int fd, void *buf, size_t count, off_t offset)
> >          ssize_t rc;
> >  
> >          current_offset = lseek(fd, 0, SEEK_CUR);
> > +	if (current_offset < 0)
> > +		return -1;
> >  
> >          if (lseek(fd, offset, SEEK_SET) < 0)
> >                  return -1;
> 
> Heh, funny. I wanted to complain about misindentation here, but your new
> code is actually indented correctly. It's everything else in this file
> that is indented with spaces.

Heh. I did notice something odd going on, thinking that Opus ignored my clear instructions about tab-indentation once again when I replaced the spaces by tabs...

Ciao, Johannes

Previous: Patrick SteinhardtNext: Johannes Schindelin via GitGitGadget
Message 13 of 60 in “coverity: fix unchecked returns”
  1. 00/11 coverity: fix unchecked returnsJohannes Schindelin via GitGitGadget, Jul 14, 2026
  2. 01/11 http: die on curl_easy_duphandle failure in get_active_slotJohannes Schindelin via GitGitGadget, Jul 14, 2026
  3. 02/11 config: propagate launch_editor() failure in show_editor()Johannes Schindelin via GitGitGadget, Jul 14, 2026
  4. Patrick SteinhardtJul 15, 2026
  5. 03/11 reftable/block: check deflateInit() return valueJohannes Schindelin via GitGitGadget, Jul 14, 2026
  6. 04/11 reftable tests: check reftable_table_init_ref_iterator() returnJohannes Schindelin via GitGitGadget, Jul 14, 2026
  7. 05/11 last-modified: handle repo_parse_commit() failuresJohannes Schindelin via GitGitGadget, Jul 14, 2026
  8. Junio C HamanoJul 15, 2026
  9. Junio C HamanoJul 20, 2026
  10. Johannes SchindelinAug 5, 2026
  11. 06/11 compat/pread: check initial lseek for errorsJohannes Schindelin via GitGitGadget, Jul 14, 2026
  12. Patrick SteinhardtJul 15, 2026
  13. Johannes SchindelinAug 5, 2026
  14. 07/11 transport-helper: check dup() return in get_exporterJohannes Schindelin via GitGitGadget, Jul 14, 2026
  15. Patrick SteinhardtJul 15, 2026
  16. 08/11 transport-helper: warn when export-marks file cannot be finalizedJohannes Schindelin via GitGitGadget, Jul 14, 2026
  17. 09/11 bisect: check strbuf_getline_lf return when reading termsJohannes Schindelin via GitGitGadget, Jul 14, 2026
  18. Junio C HamanoJul 15, 2026
  19. Junio C HamanoJul 20, 2026
  20. Johannes SchindelinAug 5, 2026
  21. 10/11 bisect: check get_terms return at all call sitesJohannes Schindelin via GitGitGadget, Jul 14, 2026
  22. Patrick SteinhardtJul 15, 2026
  23. Johannes SchindelinAug 5, 2026
  24. 11/11 bisect: handle dup() failure when redirecting stdoutJohannes Schindelin via GitGitGadget, Jul 14, 2026
  25. Patrick SteinhardtJul 15, 2026
  26. Johannes SchindelinAug 5, 2026
  27. 00/11 coverity: fix unchecked returnsJohannes Schindelin via GitGitGadget, Aug 5, 2026
  28. 01/11 http: die on curl_easy_duphandle failure in get_active_slotJohannes Schindelin via GitGitGadget, Aug 5, 2026
  29. 02/11 config: propagate launch_editor() failure in show_editor()Johannes Schindelin via GitGitGadget, Aug 5, 2026
  30. 03/11 reftable/block: check deflateInit() return valueJohannes Schindelin via GitGitGadget, Aug 5, 2026
  31. Junio C HamanoAug 6, 2026
  32. 04/11 reftable tests: check reftable_table_init_ref_iterator() returnJohannes Schindelin via GitGitGadget, Aug 5, 2026
  33. 05/11 last-modified: handle repo_parse_commit() failuresJohannes Schindelin via GitGitGadget, Aug 5, 2026
  34. 06/11 compat/pread: check initial lseek for errorsJohannes Schindelin via GitGitGadget, Aug 5, 2026
  35. 07/11 transport-helper: check dup() return in get_exporterJohannes Schindelin via GitGitGadget, Aug 5, 2026
  36. 08/11 transport-helper: warn when export-marks file cannot be finalizedJohannes Schindelin via GitGitGadget, Aug 5, 2026
  37. 09/11 bisect: check strbuf_getline_lf return when reading termsJohannes Schindelin via GitGitGadget, Aug 5, 2026
  38. 10/11 bisect: check get_terms return at all call sitesJohannes Schindelin via GitGitGadget, Aug 5, 2026
  39. Junio C HamanoAug 5, 2026
  40. 11/11 bisect: handle dup() failure when redirecting stdoutJohannes Schindelin via GitGitGadget, Aug 5, 2026
  41. Jeff KingAug 6, 2026
  42. Junio C HamanoAug 6, 2026
  43. 00/12 coverity: fix unchecked returnsJohannes Schindelin via GitGitGadget, Aug 12, 2026
  44. 01/12 http: die on curl_easy_duphandle failure in get_active_slotJohannes Schindelin via GitGitGadget, Aug 12, 2026
  45. 02/12 config: propagate launch_editor() failure in show_editor()Johannes Schindelin via GitGitGadget, Aug 12, 2026
  46. 03/12 reftable: handle block-writer initialization errorsJohannes Schindelin via GitGitGadget, Aug 12, 2026
  47. 04/12 reftable/block: check deflateInit() return valueJohannes Schindelin via GitGitGadget, Aug 12, 2026
  48. 05/12 reftable tests: check reftable_table_init_ref_iterator() returnJohannes Schindelin via GitGitGadget, Aug 12, 2026
  49. 06/12 last-modified: handle repo_parse_commit() failuresJohannes Schindelin via GitGitGadget, Aug 12, 2026
  50. 07/12 compat/pread: check initial lseek for errorsJohannes Schindelin via GitGitGadget, Aug 12, 2026
  51. 08/12 transport-helper: check dup() return in get_exporterJohannes Schindelin via GitGitGadget, Aug 12, 2026
  52. 09/12 transport-helper: warn when export-marks file cannot be finalizedJohannes Schindelin via GitGitGadget, Aug 12, 2026
  53. Patrick SteinhardtAug 13, 2026
  54. 10/12 bisect: check strbuf_getline_lf return when reading termsJohannes Schindelin via GitGitGadget, Aug 12, 2026
  55. 11/12 bisect: check get_terms return at all call sitesJohannes Schindelin via GitGitGadget, Aug 12, 2026
  56. 12/12 bisect: handle dup() failure when redirecting stdoutJohannes Schindelin via GitGitGadget, Aug 12, 2026
  57. Jeff KingAug 12, 2026
  58. Junio C HamanoAug 12, 2026
  59. Jeff KingAug 12, 2026
  60. Patrick SteinhardtAug 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.