[PATCH v3 08/12] transport-helper: check dup() return in get_exporter
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Aug 12, 2026, 08:03 UTC
- Message-ID
- <689bb48fe58186b8478c30ef906ebec4a4d2e091.1786521801.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.2179.v3.git.1786521801.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
get_exporter() duplicates helper->in via dup() and stores the result in fastexport->out. If dup() fails (fd exhaustion), it returns -1. The child_process machinery interprets out = -1 as "create a pipe for stdout", which would silently change the fast-export process's output wiring: instead of sending data back through the helper's input fd, it would write to a new pipe that nobody reads from.
Check the return value and report the error before proceeding.
Pointed out by Coverity.
Assisted-by: Claude Opus 4.6 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- transport-helper.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/transport-helper.c b/transport-helper.c index 80f90eb7ba..31883b244e 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -487,6 +487,8 @@ static int get_exporter(struct transport *transport, /* we need to duplicate helper->in because we want to use it after * fastexport is done with it. */ fastexport->out = dup(helper->in); + if (fastexport->out < 0) + return error_errno(_("could not dup helper output fd")); strvec_push(&fastexport->args, "fast-export"); strvec_push(&fastexport->args, "--use-done-feature"); strvec_push(&fastexport->args, data->signed_tags ?
-- gitgitgadget