Re: [PATCH v9 0/4] hook: introduce the receive-report hook

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 9, 2026, 17:20 UTC
Message-ID: <xmqqh5jys5mx.fsf@gitster.g>
In-Reply-To: <aqF0mbWgYU5rMR-f@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 8 quoted lines

> On Wed, Sep 09, 2026 at 04:51:35PM +0200, Karthik Nayak wrote:
>> Changes in v9:
>> - Fix a bug where we were causing a BUG() when no report was requested.
>>   It is perfectly valid for clients to skip the report and we shouldn't
>>   fail when they do so. Thanks Junio!
>
> It's curious that nothing has failed because of this. Are we lacking
> tests here?

The "send-pack" client we have will ask for report if the server side advertises report-status or report-status-v2 capabilities, and there is no way to disable it nor there is no practical need to give a way to do so, so unless we are willing to write a custom client, or a configuration to disable server capability advertisement, such a test is a bit impractical to write.