Re: [PATCH v9 4/4] hook: introduce the receive-report hook

From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Sep 11, 2026, 13:54 UTC
Message-ID: <aqQIA37pZL0TZaDR@ugly.lan>
In-Reply-To: <20260909-758-introduce-hook-v9-4-3043d417e0ee@gmail.com>

On Wed, Sep 09, 2026 at 04:51:39PM +0200, Karthik Nayak wrote:

Show 6 quoted lines

>[...]
>Introduce a new 'receive-report' hook. The hook receives the complete
>pkt-line encoded status report on standard input, after all ref updates
>have been applied to the repository by execute_commands() but before the
>report is sent to the client. See linkgit:gitprotocol-pack[5] details on
>the protocol structure.

i suppose it's a matter of taste/policy, but around this point i find the commit message's verbosity to be counter-productive:

>The hook's stdout fully replaces the report sent to the client.
>[...]

i would cut it down to the parts that aren't redundant with the "proper" documentation in the diff, keeping in mind that the central question to be answered by the commit message is "why?".