Re: [PATCH v7 3/4] receive-pack: move message generation to separate function

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 7, 2026, 20:58 UTC
Message-ID: <xmqq1pb43hjh.fsf@gitster.g>
In-Reply-To: <20260904-758-introduce-hook-v7-3-6c66f0a3a572@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 6 quoted lines

> -static void report(struct command *commands, const struct strbuf *unpack_status)
> +/*
> + * Generate the response to be sent to the client invoking 'git-receive-pack(1)'.
> + * For v2 protocol, set `detailed_report` to true, which will also add detailed
> + * report per reference update.
> + */

The second sentence is stale and no longer matches the interface.

> +static void generate_report(struct strbuf *buf, struct command *commands,
> +			    const struct strbuf *unpack_status,
> +			    enum report_status_version version)
>  {

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.