Re: [PATCH v7 4/4] hook: introduce the receive-report hook

From: Karthik Nayak <karthik.188@gmail.com>
Date: Sep 8, 2026, 09:57 UTC
Message-ID: <CAOLa=ZTNMwJkXZ_CuKdR0F+_ZAxtr+eK6o=tjgUg4O4vFgPDpg@mail.gmail.com>
In-Reply-To: <xmqq7bkw3hk7.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> @@ -2469,6 +2510,12 @@ static void report(struct command *commands, const struct strbuf *unpack_status,
>>
>>  	generate_report(&buf, commands, unpack_status, version);
>>
>> +	if (run_receive_report_hook(&buf)) {
>> +		strbuf_reset(&buf);
>> +		override_cmds_error(commands, "receive-report hook failed");
>> +		generate_report(&buf, commands, unpack_status, false);
>> +	}
>
> Hmph, what does 'false' mean here?  Didn't you mean to use the same
> "version" like you used in the previous call in the preimage?

Indeed. It doesn't trip any test as we override the command error, so the version argument passed as `false` here is never used.

Will change.