Re: [PATCH 2/7] setup: introduce object storage extension
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 20, 2026, 01:27 UTC
- Message-ID
- <xmqqh5ihyxd2.fsf@gitster.g>
- In-Reply-To
- <CAOLa=ZQj0sZu7WRzmvgZx23ZeO1KBtOm6yWOLCzeVP_86zkTPQ@mail.gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 12 quoted lines
>> diff --git a/odb/source.c b/odb/source.c >> index b25ef14df8..10abe33a26 100644 >> --- a/odb/source.c >> +++ b/odb/source.c >> @@ -1,4 +1,5 @@ >> #include "git-compat-util.h" >> +#include "gettext.h" >> #include "object-file.h" >> #include "odb/source-files.h" >> #include "odb/source.h" > > Do we need this import? This commit seems to compile without it.
It is better to be explicit, rather than relying on an indirect inclusion from an unrelated header. Since odb/source.c is more or less a library-like part of the system, however, the presence of translatable messages meant for human users is a bit of a curiosity.