[PATCH v2 1/7] loose: drop unused `repo_write_loose_object_map()`
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 21, 2026, 05:39 UTC
- Message-ID
- <20261021-b4-pks-odb-extension-v2-1-8cf11b65eda8@pks.im>
- In-Reply-To
- <20261021-b4-pks-odb-extension-v2-0-8cf11b65eda8@pks.im>
The function `repo_write_loose_object_map()` was introduced in 23b2c7e95b (loose: add a mapping between SHA-1 and SHA-256 for loose objects, 2023-10-01), but it never had any callers as loose object maps are instead written incrementally via `repo_add_loose_object_map()` whenever a new loose object is created.
Besides being dead code, the function also hardcodes the location of the "loose-object-idx" file as "$GIT_COMMON_DIR/objects", whereas both the reader and `repo_add_loose_object_map()` derive the location from the loose source's path. The function would thus disagree with everyone else where the loose object map is supposed to be located when the object directory is using a non-default location.
Remove the function.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- loose.c | 46 ---------------------------------------------- loose.h | 1 - 2 files changed, 47 deletions(-)
diff --git a/loose.c b/loose.c index d6a2bb5ba3..7e26a04ec0 100644 --- a/loose.c +++ b/loose.c @@ -123,52 +123,6 @@ int repo_read_loose_object_map(struct repository *repo) return 0; } -int repo_write_loose_object_map(struct repository *repo) -{ - struct odb_source_files *files = odb_source_files_downcast(repo->objects->source); - kh_oid_map_t *map = files->dirs->loose->map->to_compat; - struct lock_file lock; - int fd; - khiter_t iter; - struct strbuf buf = STRBUF_INIT, path = STRBUF_INIT; - - if (!should_use_loose_object_map(repo)) - return 0; - - repo_common_path_replace(repo, &path, "objects/loose-object-idx"); - fd = repo_hold_lock_file_for_update_timeout(repo, &lock, path.buf, - LOCK_DIE_ON_ERROR, -1); - iter = kh_begin(map); - if (write_in_full(fd, loose_object_header, strlen(loose_object_header)) < 0) - goto errout; - - for (; iter != kh_end(map); iter++) { - if (kh_exist(map, iter)) { - if (oideq(&kh_key(map, iter), repo->hash_algo->empty_tree) || - oideq(&kh_key(map, iter), repo->hash_algo->empty_blob)) - continue; - strbuf_addf(&buf, "%s %s\n", oid_to_hex(&kh_key(map, iter)), oid_to_hex(kh_value(map, iter))); - if (write_in_full(fd, buf.buf, buf.len) < 0) - goto errout; - strbuf_reset(&buf); - } - } - strbuf_release(&buf); - if (commit_lock_file(&lock) < 0) { - error_errno(_("could not write loose object index %s"), path.buf); - strbuf_release(&path); - return -1; - } - strbuf_release(&path); - return 0; -errout: - rollback_lock_file(&lock); - strbuf_release(&buf); - error_errno(_("failed to write loose object index %s"), path.buf); - strbuf_release(&path); - return -1; -} - static int write_one_object(struct odb_source_loose *loose, const struct object_id *oid, const struct object_id *compat_oid) diff --git a/loose.h b/loose.h index ed663ac550..41c4b46818 100644 --- a/loose.h +++ b/loose.h @@ -22,6 +22,5 @@ int repo_add_loose_object_map(struct odb_source_loose *loose, const struct object_id *oid, const struct object_id *compat_oid); int repo_read_loose_object_map(struct repository *repo); -int repo_write_loose_object_map(struct repository *repo); #endif
-- 2.56.0.307.g5fe7bd680c.dirty