Re: [PATCH 4/7] builtin: expose the object storage format
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Oct 20, 2026, 19:10 UTC
- Message-ID
- <CAOLa=ZSTt1vcqOtKAfRJMvpkXsJgHbDP-jedOLPkTZGY+HFeMA@mail.gmail.com>
- In-Reply-To
- <atcrRWX2-S9374Sy@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 29 quoted lines
> On Mon, Oct 19, 2026 at 02:40:31PM -0700, Karthik Nayak wrote: >> Patrick Steinhardt <ps@pks.im> writes: >> > diff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc >> > index cb8c1e7292..d2dc9b7a69 100644 >> > --- a/Documentation/git-repo.adoc >> > +++ b/Documentation/git-repo.adoc >> > @@ -105,6 +105,12 @@ values that they return: >> > `object.format`:: >> > The object format (hash algorithm) used in the repository. >> > >> > +`objects.storageFormat`:: >> > + The object storage format used in the repository, as configured via >> > + `extensions.objectStorage`. The valid values are: >> > ++ >> >> The nuance between `object` above and `objects` here is too little and >> can be confusing. But there's nothing we can really do here. > > Yeah, I'm not a fan of this, either. It used to be even worse than that, > because we had "references.format" which was giving us information about > the backend that our refs use. And that's why I recently sent the patch > series to rename "ref format" to "ref storage format", so that we can > avoid this conflict here. > > It's still not perfect to have both "object.format" and > "objects.storageFormat". I was wondering whether we also want to rename > "object.format" to "objects.format" to at least have the prefix match. > But I shied away from that. >
But then you'd have to also rename the config options for the same no? I'd leave that out of this series.
[snip]