Re: [PATCH v3 2/7] setup: introduce object storage extension
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 26, 2026, 11:53 UTC
- Message-ID
- <at8_RyoMSePPIUyb@pks.im>
- In-Reply-To
- <CAOLa=ZTwedYbV+vFJcrACohX+epp4hUXSFXYvRTZ1tJPSNaj9A@mail.gmail.com>
On Mon, Oct 26, 2026 at 04:22:38AM -0700, Karthik Nayak wrote:
Show 18 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/odb.c b/odb.c
> > index 98c5c862f5..0649622bc6 100644
> > --- a/odb.c
> > +++ b/odb.c
> > @@ -27,6 +27,42 @@
> > #include "trace2.h"
> > #include "write-or-die.h"
> >
> > +static const char * const object_storage_name_by_format[] = {
> > + [OBJECT_STORAGE_FORMAT_UNKNOWN] = "unknown",
> > + [OBJECT_STORAGE_FORMAT_FILES] = "files",
> > +};
> > +
>
> Super Nit: I would have dropped from this, as that is the default, this
> makes it seem like it is one of the backends. Feel free to ignore
> though.Hm. I need the `OBJECT_STORAGE_FORMAT_UNKNOWN` enum value anyway, so if I were to drop that backend above I'd have to add another special case to handle the case where its value is `NULL`. So I'd prefer to keep this as-is.
Show 11 quoted lines
> > diff --git a/repository.h b/repository.h > > index 2a348012e8..8c4437762e 100644 > > --- a/repository.h > > +++ b/repository.h > > @@ -694,6 +708,7 @@ static enum extension_result handle_extension(const char *var, > > data->submodule_path_cfg = git_config_bool(var, value); > > return EXTENSION_OK; > > } > > + > > Nit: stray newline addition
I was confused at first because you snipped to the wrong diff header -- this is in "setup.c", not in "repository.h". Fixed now.
Patrick