git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/9] push tests: make use of unused $1 in test description

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 31, 2018, 21:07 UTC
Message-ID
<xmqqftyu1byv.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180831201004.12087-3-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
Show 21 quoted lines
> Fix up a logic error in 380efb65df ("push tests: assert re-pushing
> annotated tags", 2018-07-31), where the $tag_type_description variable
> was assigned to but never used, unlike in the subsequently added
> companion test for fetches in 2d216a7ef6 ("fetch tests: add a test for
> clobbering tag behavior", 2018-04-29).
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/t5516-fetch-push.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
> index 539c25aada..62d5059f92 100755
> --- a/t/t5516-fetch-push.sh
> +++ b/t/t5516-fetch-push.sh
> @@ -969,7 +969,7 @@ test_force_push_tag () {
>  	tag_type_description=$1
>  	tag_args=$2
>  
> -	test_expect_success 'force pushing required to update lightweight tag' "
> +	test_expect_success 'force pushing required to update $tag_type_description' "

Of course, $1 needs to be inside "dq-pair" for $tag_type_description to be substituted ;-) So I'll tweak it while queuing.

All the other ones in this series looked sensible to me. Will replace.

Thanks.
>  		mk_test testrepo heads/master &&
>  		mk_child testrepo child1 &&
>  		mk_child testrepo child2 &&
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 56 of 101 in “Fetching tags overwrites existing tags”
  1. Wink SavilleApr 24, 2018
  2. Jacob KellerApr 24, 2018
  3. Junio C HamanoApr 25, 2018
  4. Jacob KellerApr 25, 2018
  5. Wink SavilleApr 25, 2018
  6. Wink SavilleApr 26, 2018
  7. Junio C HamanoApr 26, 2018
  8. Junio C HamanoApr 26, 2018
  9. Teach remote add the --prefix-tags optionWink Saville, Apr 27, 2018
  10. Wink SavilleApr 27, 2018
  11. Bryan TurnerApr 27, 2018
  12. Jacob KellerMay 4, 2018
  13. Jacob KellerApr 28, 2018
  14. Teach remote add the --remote-tags optionWink Saville, Apr 28, 2018
  15. Wink SavilleApr 28, 2018
  16. Wink SavilleApr 28, 2018
  17. 0/3 Optional sub hierarchy for remote tagsWink Saville, May 1, 2018
  18. 1/3 Teach remote add the --remote-tags optionWink Saville, May 1, 2018
  19. Ævar Arnfjörð BjarmasonMay 1, 2018
  20. Kaartic SivaraamMay 8, 2018
  21. 2/3 Teach tag to list remote-tagsWink Saville, May 1, 2018
  22. 3/3 Test git remote add -f --remote-tagsWink Saville, May 1, 2018
  23. Ævar Arnfjörð BjarmasonMay 1, 2018
  24. Jacob KellerMay 1, 2018
  25. Wink SavilleMay 1, 2018
  26. Junio C HamanoMay 1, 2018
  27. Jacob KellerMay 2, 2018
  28. Junio C HamanoMay 1, 2018
  29. Ævar Arnfjörð BjarmasonApr 27, 2018
  30. 0/8 "git fetch" should not clobber existing tags without --forceÆvar Arnfjörð Bjarmason, Apr 29, 2018
  31. 1/8 push tests: remove redundant 'git push' invocationÆvar Arnfjörð Bjarmason, Apr 29, 2018
  32. 2/8 push tests: fix logic error in "push" test assertionÆvar Arnfjörð Bjarmason, Apr 29, 2018
  33. 3/8 push tests: add more testing for forced tag pushingÆvar Arnfjörð Bjarmason, Apr 29, 2018
  34. Kaartic SivaraamMay 7, 2018
  35. Junio C HamanoMay 8, 2018
  36. Junio C HamanoMay 8, 2018
  37. Kaartic SivaraamMay 8, 2018
  38. Kaartic SivaraamMay 8, 2018
  39. 4/8 push tests: assert re-pushing annotated tagsÆvar Arnfjörð Bjarmason, Apr 29, 2018
  40. Junio C HamanoMay 8, 2018
  41. SZEDER GáborMay 8, 2018
  42. 6/8 fetch tests: correct a comment "remove it" -> "remove them"Ævar Arnfjörð Bjarmason, Apr 29, 2018
  43. 5/8 push doc: correct lies about how push refspecs workÆvar Arnfjörð Bjarmason, Apr 29, 2018
  44. Junio C HamanoMay 8, 2018
  45. 8/8 fetch: stop clobbering existing tags without --forceÆvar Arnfjörð Bjarmason, Apr 29, 2018
  46. Junio C HamanoMay 8, 2018
  47. 7/8 fetch tests: add a test clobbering tag behaviorÆvar Arnfjörð Bjarmason, Apr 29, 2018
  48. 00/10 "git fetch" should not clobber existing tags without --forceÆvar Arnfjörð Bjarmason, Jul 31, 2018
  49. 0/7 Prep for "git fetch" should not clobber existing tags without --forceÆvar Arnfjörð Bjarmason, Aug 13, 2018
  50. Junio C HamanoAug 13, 2018
  51. Ævar Arnfjörð BjarmasonAug 13, 2018
  52. 0/6 "git fetch" should not clobber existing tags without --forceÆvar Arnfjörð Bjarmason, Aug 30, 2018
  53. 0/9 git fetch" should not clobber existing tags without --forceÆvar Arnfjörð Bjarmason, Aug 31, 2018
  54. 1/9 fetch: change "branch" to "reference" in --force -h outputÆvar Arnfjörð Bjarmason, Aug 31, 2018
  55. 2/9 push tests: make use of unused $1 in test descriptionÆvar Arnfjörð Bjarmason, Aug 31, 2018
  56. Junio C HamanoAug 31, 2018
  57. Ævar Arnfjörð BjarmasonAug 31, 2018
  58. 3/9 push tests: use spaces in interpolated stringÆvar Arnfjörð Bjarmason, Aug 31, 2018
  59. 4/9 fetch tests: add a test for clobbering tag behaviorÆvar Arnfjörð Bjarmason, Aug 31, 2018
  60. 5/9 push doc: remove confusing mention of remote mergerÆvar Arnfjörð Bjarmason, Aug 31, 2018
  61. 6/9 push doc: move mention of "tag <tag>" later in the proseÆvar Arnfjörð Bjarmason, Aug 31, 2018
  62. 7/9 push doc: correct lies about how push refspecs workÆvar Arnfjörð Bjarmason, Aug 31, 2018
  63. 8/9 fetch: document local ref updates with/without --forceÆvar Arnfjörð Bjarmason, Aug 31, 2018
  64. 9/9 fetch: stop clobbering existing tags without --forceÆvar Arnfjörð Bjarmason, Aug 31, 2018
  65. 1/6 fetch: change "branch" to "reference" in --force -h outputÆvar Arnfjörð Bjarmason, Aug 30, 2018
  66. 2/6 push tests: correct quoting in interpolated stringÆvar Arnfjörð Bjarmason, Aug 30, 2018
  67. Junio C HamanoAug 30, 2018
  68. 3/6 fetch tests: add a test for clobbering tag behaviorÆvar Arnfjörð Bjarmason, Aug 30, 2018
  69. Junio C HamanoAug 30, 2018
  70. 4/6 push doc: correct lies about how push refspecs workÆvar Arnfjörð Bjarmason, Aug 30, 2018
  71. Junio C HamanoAug 30, 2018
  72. Ævar Arnfjörð BjarmasonAug 30, 2018
  73. Junio C HamanoAug 31, 2018
  74. Ævar Arnfjörð BjarmasonAug 31, 2018
  75. 5/6 fetch: document local ref updates with/without --forceÆvar Arnfjörð Bjarmason, Aug 30, 2018
  76. 6/6 fetch: stop clobbering existing tags without --forceÆvar Arnfjörð Bjarmason, Aug 30, 2018
  77. Junio C HamanoAug 30, 2018
  78. 2/7 push tests: remove redundant 'git push' invocationÆvar Arnfjörð Bjarmason, Aug 13, 2018
  79. 3/7 push tests: fix logic error in "push" test assertionÆvar Arnfjörð Bjarmason, Aug 13, 2018
  80. 4/7 push tests: add more testing for forced tag pushingÆvar Arnfjörð Bjarmason, Aug 13, 2018
  81. 5/7 push tests: assert re-pushing annotated tagsÆvar Arnfjörð Bjarmason, Aug 13, 2018
  82. 6/7 fetch tests: correct a comment "remove it" -> "remove them"Ævar Arnfjörð Bjarmason, Aug 13, 2018
  83. 7/7 pull doc: fix a long-standing grammar errorÆvar Arnfjörð Bjarmason, Aug 13, 2018
  84. 1/7 fetch tests: change "Tag" test tag to "testTag"Ævar Arnfjörð Bjarmason, Aug 13, 2018
  85. 01/10 fetch tests: change "Tag" test tag to "testTag"Ævar Arnfjörð Bjarmason, Jul 31, 2018
  86. 02/10 push tests: remove redundant 'git push' invocationÆvar Arnfjörð Bjarmason, Jul 31, 2018
  87. 03/10 push tests: fix logic error in "push" test assertionÆvar Arnfjörð Bjarmason, Jul 31, 2018
  88. 04/10 push tests: add more testing for forced tag pushingÆvar Arnfjörð Bjarmason, Jul 31, 2018
  89. 05/10 push tests: assert re-pushing annotated tagsÆvar Arnfjörð Bjarmason, Jul 31, 2018
  90. 06/10 push doc: correct lies about how push refspecs workÆvar Arnfjörð Bjarmason, Jul 31, 2018
  91. Junio C HamanoJul 31, 2018
  92. Ævar Arnfjörð BjarmasonAug 30, 2018
  93. Junio C HamanoAug 30, 2018
  94. Ævar Arnfjörð BjarmasonAug 30, 2018
  95. 08/10 fetch tests: add a test clobbering tag behaviorÆvar Arnfjörð Bjarmason, Jul 31, 2018
  96. Junio C HamanoJul 31, 2018
  97. 07/10 fetch tests: correct a comment "remove it" -> "remove them"Ævar Arnfjörð Bjarmason, Jul 31, 2018
  98. 09/10 pull doc: fix a long-standing grammar errorÆvar Arnfjörð Bjarmason, Jul 31, 2018
  99. 10/10 fetch: stop clobbering existing tags without --forceÆvar Arnfjörð Bjarmason, Jul 31, 2018
  100. Junio C HamanoJul 31, 2018
  101. Wink SavilleMay 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.