Re: Fetching tags overwrites existing tags
- From
Bryan Turner <bturner@atlassian.com>
- Date
- Apr 27, 2018, 19:13 UTC
- Message-ID
- <CAGyf7-GhK_wAZn8zO35rsgQ=meLc=Lr+Q=S8omHg1c413dMsFw@mail.gmail.com>
- In-Reply-To
- <CAKk8isqAd11W4DpjNkd9AeMDGi=ESyhVSFXcvwteasTfHMPGLA@mail.gmail.com>
On Fri, Apr 27, 2018 at 12:08 PM, Wink Saville <wink@saville.com> wrote:
> > The other change was rather than using ""+refs/tags/*:refs/remote-tags/$name/*" > I've changed it to "+refs/tags/*:refs/remote/tags/$name/*" which seems cleaner. > Again, if remote-tags is preferred I'll change it back.
From looking at the code, it looks like you mean "+refs/tags/*:refs/remotes/tags/$name/*".
The issue with that approach is that it collides with a remote named "tags". "refs/remote-tags", on the other hand, represents a new-to-Git path, one that won't already be in use by any other standard functionality. That seems like a better approach than hoping no one out there will call one of their remotes "tags".
Bryan