[PATCH v3 3/7] push tests: fix logic error in "push" test assertion
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Aug 13, 2018, 19:22 UTC
- Message-ID
- <20180813192249.27585-4-avarab@gmail.com>
- In-Reply-To
- <20180731130718.25222-1-avarab@gmail.com>
Fix a logic error that's been here since this test was added in dbfeddb12e ("push: require force for refs under refs/tags/", 2012-11-29).
The intent of this test is to force-create a new tag pointing to HEAD~, and then assert that pushing it doesn't work without --force.
Instead, the code was not creating a new tag at all, and then failing to push the previous tag for the unrelated reason of providing a refspec that doesn't make any sense.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- t/t5516-fetch-push.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh index 59d7ea689a..fbc44273d9 100755 --- a/t/t5516-fetch-push.sh +++ b/t/t5516-fetch-push.sh @@ -979,8 +979,8 @@ test_expect_success 'push requires --force to update lightweight tag' ' git tag -f testTag && test_must_fail git push ../child2 testTag && git push --force ../child2 testTag && - git tag -f testTag && - test_must_fail git push ../child2 testTag HEAD~ && + git tag -f testTag HEAD~ && + test_must_fail git push ../child2 testTag && git push --force ../child2 testTag ) '
-- 2.18.0.345.g5c9ce644c3