Re: Fetching tags overwrites existing tags
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- May 4, 2018, 15:56 UTC
- Message-ID
- <CA+P7+xp_FWrvY8M+K_1ogK27Rm0pDvBDL73n7nFu34tv557vKg@mail.gmail.com>
- In-Reply-To
- <CAGyf7-GhK_wAZn8zO35rsgQ=meLc=Lr+Q=S8omHg1c413dMsFw@mail.gmail.com>
On Fri, Apr 27, 2018 at 12:13 PM, Bryan Turner <bturner@atlassian.com> wrote:
Show 17 quoted lines
> On Fri, Apr 27, 2018 at 12:08 PM, Wink Saville <wink@saville.com> wrote: >> >> The other change was rather than using ""+refs/tags/*:refs/remote-tags/$name/*" >> I've changed it to "+refs/tags/*:refs/remote/tags/$name/*" which seems cleaner. >> Again, if remote-tags is preferred I'll change it back. > > > From looking at the code, it looks like you mean > "+refs/tags/*:refs/remotes/tags/$name/*". > > The issue with that approach is that it collides with a remote named > "tags". "refs/remote-tags", on the other hand, represents a new-to-Git > path, one that won't already be in use by any other standard > functionality. That seems like a better approach than hoping no one > out there will call one of their remotes "tags". > > Bryan
Note that my suggestion was very specific "remote" not pluralized, which is obviously a bit confusing, since there's remote and "remotes".
The goal being that you put "remote/<name>/" followed by the full remote ref minus the refs prefix.
It specifically is attempting to avoid the problem of expanding "remotes". Unfortunately, I don't have a better alternative format, and i very much want to avoid having to do "remote-tags", "remote-notes", "remote-replaces", "remote-meta" etc...
In that spirit, I'm working to hopefully propose something today.
Thanks, Jake