Re: [PATCH v2 7/8] submodule--helper: remove unused helpers

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2021, 17:19 UTC
Message-ID: <xmqqfstzcggs.fsf@gitster.g>
In-Reply-To: <20210916103241.62376-8-raykar.ath@gmail.com>

Atharva Raykar <raykar.ath@gmail.com> writes:

Show 9 quoted lines

> These helpers were useful back when 'submodule update' had most of its
> logic in shell. Now that they will never be invoked, let us remove them.
>
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Shourya Shukla <periperidip@gmail.com>
> Signed-off-by: Atharva Raykar <raykar.ath@gmail.com>
> ---
>  builtin/submodule--helper.c | 135 ------------------------------------
>  1 file changed, 135 deletions(-)

Makes sense. I briefly hoped that print-default-remote could go after 2/8 but there is another user that is in the cmd_update() that is not removed until 5/8 and removing them in a separate step after we are all done like this patch does makes sense. I am not sure where and how the line to separate the two "remove" patches is drawn, though. Is there a reason why they need to be two patches?