Re: [PATCH v7 00/20] submodule: convert the rest of 'update' to C

From: Glen Choo <chooglen@google.com>
Date: Feb 15, 2022, 09:47 UTC
Message-ID: <kl6lwnhw5umo.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <kl6la6et76bb.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

Show 11 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> I can merge this to seen minus the above two topics and get it
>> compile, but it also seems to have some interaction with 961b130d
>> (branch: add --recurse-submodules option for branch creation,
>> 2022-01-28) and makes the t3207, tests added by that other topic,
>> fail X-<.
>
> Oof, that's embarrassing of me, let me take a look at that. There's a
> nontrivial chance that the "branch --recurse-submodules" tests caught an
> actual regression.

Looks like this is the case - t3207 caught a regression in how "git submodule update" sets the refspec of nested submodules.

Looks like our concerns about the test suite are well-founded..