Re: [PATCH v6 0/2] hook API: connect hooks to the TTY again, fixes a v2.36.0 regression
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 12 quoted lines
> This series fixes a v2.36.0 regression[1]. See [2] for the v5. The
> reasons for why a regression needs this relatively large change to
> move forward is discussed in past rounds, e.g. around [3]. CI at
> https://github.com/avar/git/actions/runs/2448496389
>
> Changes since v5:
>
> * Make the hook run test more meaningful, we now test with "-t" in
> the hook, instead of redirecting one of STDOUT or STDERR.
>
> * Add a test for both "git hook run" and "git commit", to showh that
> the "git hook run" command and one "real" user of it agree.
Thanks for a careful review and a timely response.
Show 10 quoted lines
>
> 1. https://lore.kernel.org/git/cover-v5-0.2-00000000000-20220602T131858Z-avarab@gmail.com/
>
> Ævar Arnfjörð Bjarmason (2):
> run-command: add an "ungroup" option to run_process_parallel()
> hook API: fix v2.36.0 regression: hooks should be connected to a TTY
>
> Ævar Arnfjörð Bjarmason (2):
> run-command: add an "ungroup" option to run_process_parallel()
> hook API: fix v2.36.0 regression: hooks should be connected to a TTY
Puzzling. Perhaps copy-and-paste mistake we can ignore.
Show 7 quoted lines
> hook.c | 1 +
> run-command.c | 70 +++++++++++++++++++++++++++----------
> run-command.h | 30 ++++++++++++----
> t/helper/test-run-command.c | 22 ++++++++++--
> t/t0061-run-command.sh | 30 ++++++++++++++++
> t/t1800-hook.sh | 31 ++++++++++++++++
> 6 files changed, 155 insertions(+), 29 deletions(-)
Junio C Hamano <gitster@pobox.com>