Re: [PATCH v4 0/2] hook API: connect hooks to the TTY again, fixes a v2.36.0 regression

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 1, 2022, 16:53 UTC
Message-ID: <nycvar.QRO.7.76.6.2206011850460.349@tvgsbejvaqbjf.bet>
In-Reply-To: <cover-v4-0.2-00000000000-20220531T173005Z-avarab@gmail.com>

Hi Ævar,

On Tue, 31 May 2022, Ævar Arnfjörð Bjarmason wrote:

> Ævar Arnfjörð Bjarmason (2):
>   run-command: add an "ungroup" option to run_process_parallel()
>   hook API: fix v2.36.0 regression: hooks should be connected to a TTY

As I mentioned in the review of the first patch, this introduces a feature with enough code that it is quite easy for more regressions to lurk in there.

One thing that is notably missing from the cover letter is a discussion how the current approach compares to either reverting the patches that introduced the regression or alternatively patching the code in `hook.c` to avoid using the `run_processes_parallel()` API altogether.

Ciao, Johannes