Re: [PATCH 4/6] hook tests: fix redirection logic error in 96e7225b310
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 23, 2022, 03:54 UTC
- Message-ID
- <xmqqczh84fpy.fsf@gitster.g>
- In-Reply-To
- <patch-4.6-cf62569b2e0-20220421T122108Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 7 quoted lines
> The tests added in 96e7225b310 (hook: add 'run' subcommand, > 2021-12-22) were redirecting to "actual" both in the body of the hook > itself and in the testing code below. > > The net result was that the "2>>actual" redirection later in the test > wasn't doing anything. Let's have those redirection do what it looks > like they're doing.
And the error didn't affect the outcome of the tests? This is fun.
Nicely spotted.
Show 18 quoted lines
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > t/t1800-hook.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh > index 26ed5e11bc8..1e4adc3d53e 100755 > --- a/t/t1800-hook.sh > +++ b/t/t1800-hook.sh > @@ -94,7 +94,7 @@ test_expect_success 'git hook run -- out-of-repo runs excluded' ' > test_expect_success 'git -c core.hooksPath=<PATH> hook run' ' > mkdir my-hooks && > write_script my-hooks/test-hook <<-\EOF && > - echo Hook ran $1 >>actual > + echo Hook ran $1 > EOF > > cat >expect <<-\EOF &&