Re: [PATCH 2/2] pack-bitmap: drop --unpacked non-commit objects from results

From

Junio C Hamano <gitster@pobox.com>

Date

Nov 7, 2023, 02:20 UTC

Message-ID

<xmqqfs1ib8xu.fsf@gitster.g>

In-Reply-To

<7492dc699052a392d2fb394e1dcfabebac82ded0.1699311386.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

The same comment to the commit title applies here.

> .... Note that we do not have to
> inspect individual bits in the result bitmap, since we know that the
> first N (where N is the number of objects in the bitmap's pack/MIDX)
> bits correspond to objects which packed by definition.

;-)

> +test_expect_success 'bitmap traversal with --unpacked' '
> +	git repack -adb &&
> +	test_commit unpacked &&
> +
> +	git rev-list --objects --no-object-names unpacked^.. >expect.raw &&
> +	sort expect.raw >expect &&
> +
> +	git rev-list --use-bitmap-index --objects --all --unpacked >actual.raw &&
> +	sort actual.raw >actual &&
> +
> +	test_cmp expect actual
> +'

OK.