Re: [PATCH 2/2] pack-bitmap: drop --unpacked non-commit objects from results

From: Jeff King <peff@peff.net>
Date: Nov 7, 2023, 03:52 UTC
Message-ID: <20231107035252.GB873619@coredump.intra.peff.net>
In-Reply-To: <7492dc699052a392d2fb394e1dcfabebac82ded0.1699311386.git.me@ttaylorr.com>

On Mon, Nov 06, 2023 at 05:56:33PM -0500, Taylor Blau wrote:

> Before returning a bitmap containing the result of the traversal back to
> the caller, drop any bits from the extended index which appear in one or
> more packs. This implements the correct behavior for rev-list operations
> which use the bitmap index to compute their result.

Nice. I was very happy to see the extra test for "rev-list --disk-usage" to demonstrate this. The same should apply for "pack-objects --unpacked --use-bitmap-index" (though in practice I don't think we'd do that, as "--unpacked" implies on-disk repacking, which we do not generally use with bitmaps).

-Peff