git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] revision: exclude all packed objects with `--unpacked`

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 7, 2023, 09:43 UTC
Message-ID
<ZUoGoYpJFvGSll-u@tanuki>
In-Reply-To
<20231107040235.GD873619@coredump.intra.peff.net>
On Mon, Nov 06, 2023 at 11:02:35PM -0500, Jeff King wrote:
Show 22 quoted lines
> On Mon, Nov 06, 2023 at 05:56:27PM -0500, Taylor Blau wrote:
> 
> > While working on my longer series to enable verbatim pack reuse across
> > multiple packs[^1], I noticed a couple of oddities with the `--unpacked`
> > rev-walk flag.
> > 
> > While it does exclude packed commits, it does not exclude (all) packed
> > trees/blobs/annotated tags. This problem exists in the pack-bitmap
> > machinery, too, which will over-count queries like:
> > 
> >     $ git rev-list --use-bitmap-index --all --unpacked --objects
> > 
> > , etc.
> > 
> > The fix is relatively straightforward, split across two patches that
> > Peff and I worked on together earlier today.
> 
> I'm not sure my review is worth anything, but this looks good to me. ;)
> I do think it might be worth tightening up the docs as Junio suggested,
> but I would be fine to see that as a patch on top.
> 
> -Peff

I also read through the patches and agree, this looks good to me. Thanks!

Patrick
Previous: Jeff King
Message 10 of 10 in “revision: exclude all packed objects with `--unpacked`”
  1. 0/2 revision: exclude all packed objects with `--unpacked`Taylor Blau, Nov 6, 2023
  2. 1/2 list-objects: drop --unpacked non-commit objects from resultsTaylor Blau, Nov 6, 2023
  3. Junio C HamanoNov 7, 2023
  4. Jeff KingNov 7, 2023
  5. 2/2 pack-bitmap: drop --unpacked non-commit objects from resultsTaylor Blau, Nov 6, 2023
  6. Junio C HamanoNov 7, 2023
  7. Jeff KingNov 7, 2023
  8. Junio C HamanoNov 7, 2023
  9. Jeff KingNov 7, 2023
  10. Patrick SteinhardtNov 7, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.