Re: [PATCH 0/2] revision: exclude all packed objects with `--unpacked`

From: Jeff King <peff@peff.net>
Date: Nov 7, 2023, 04:02 UTC
Message-ID: <20231107040235.GD873619@coredump.intra.peff.net>
In-Reply-To: <cover.1699311386.git.me@ttaylorr.com>

On Mon, Nov 06, 2023 at 05:56:27PM -0500, Taylor Blau wrote:

Show 14 quoted lines

> While working on my longer series to enable verbatim pack reuse across
> multiple packs[^1], I noticed a couple of oddities with the `--unpacked`
> rev-walk flag.
> 
> While it does exclude packed commits, it does not exclude (all) packed
> trees/blobs/annotated tags. This problem exists in the pack-bitmap
> machinery, too, which will over-count queries like:
> 
>     $ git rev-list --use-bitmap-index --all --unpacked --objects
> 
> , etc.
> 
> The fix is relatively straightforward, split across two patches that
> Peff and I worked on together earlier today.

I'm not sure my review is worth anything, but this looks good to me. ;) I do think it might be worth tightening up the docs as Junio suggested, but I would be fine to see that as a patch on top.

-Peff