Re: [PATCH v17 1/2] refactor format_branch_comparison in preparation

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 10, 2026, 17:31 UTC
Message-ID: <xmqqfr8ds7br.fsf@gitster.g>
In-Reply-To: <20260110110629.18501-1-haraldnordgren@gmail.com>

Harald Nordgren <haraldnordgren@gmail.com> writes:

> I can rename the sti's to 'cmp_fetch' and 'cmp_fetch_push', but does it
> help?

Not at all. Unless the contrast were "something_fetch" vs "something_push", that is. And that something being cryptic "sti" (recall my comment on it, being the name of the function that returns the value, which is less understandable than using words that signals what the variable _means_), would not make much sense for the "push" direction, as "sti" is not even an abbreviation for the function that gives the value. "cmp" (or "compare" for that matter) still has the ambiguity "compare with what and what for?", but at least it would be better than "sti".

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.