Re: [PATCH v17 1/2] refactor format_branch_comparison in preparation

From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Jan 9, 2026, 18:03 UTC
Message-ID: <20260109180309.14669-1-haraldnordgren@gmail.com>
In-Reply-To: <aWEtp77UB30SbKle@pks.im>

Show 6 quoted lines

> > I think other uses in Git declare a bunch of integer constants for the
> > bitfields, not an enum. Why? Because or-ing flags together creates a
> > value not in the enum…
> 
> We nowadays typically declare the flags as enum, but when accepting the
> bitfield we use `unsigned`.

Good points! I have updated it to remove the name branch_mode_flags now, define the enums and pass them around as unsigned now. Will be in the next patch.

Harald

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.