Re: [PATCH v27 0/2] status: add status.compareBranches config for multiple branch comparisons
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 22, 2026, 20:18 UTC
- Message-ID
- <xmqqcy31mmex.fsf@gitster.g>
- In-Reply-To
- <20260122192238.76368-1-haraldnordgren@gmail.com>
Harald Nordgren <haraldnordgren@gmail.com> writes:
Show 17 quoted lines
>> Using a string list like this is quadratic. It probably doesn't matter >> too much here since we wouldn't expect the list of configured branches >> to be very long, though. But a strset is probably the better tool, like >> the diff below (note that its "add" can be used as a single operation to >> insert and check). >> >> I don't know if it's worth re-rolling for this or not. I doubt anybody >> would hit it in practice, but I'd be more concerned about people >> auditing for accidentally-quadratic uses of string_list and stumbling >> upon it. > > Sounds like a good change. Very nice to have insert-and-check as a single > operation! > > I'll update it after passing CI on GitHub -- I'm running CI from two > separate GitHub pull requests, because one has your memory leak fix on top > to allow the leak tests to not fail. 🤗
Thanks. I think we are getting to the finish line with this topic, finally ;-)