Re: [PATCH v14 1/5] fetch: add remote.<name>.fetchRefmap
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2026, 21:06 UTC
- Message-ID
- <xmqqfqwzcgmu.fsf@gitster.g>
- In-Reply-To
- <c40477c7-e1d8-4af1-859b-b739dac4bc86@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 6 quoted lines
>> I can buy it if the suggestion was to allow passing --no-refmap from >> the command line (or would --refmap="" work?) to ignore .fetchRefmap >> configuration, though. > > I think --refmap="" might work as --refmap overrides the config and > --refmap="" is the documented way to ignore the ".fetch" config.
Do you mean ... ignore the .fetchRefmap config (not ".fetch", which is used as the default for refspecs and not value to a dashed option)?
All that said, it feels much more flexible if a refspec with a destination (whether on the command line or in the configuration) simply ignores the refmap. In other words, the refmap would only apply to refspec entries that lack a destination, leaving elements with their own destination untouched.
This way, we won't have to worry about what --refmap="" means.
So I'm completely fine with going in that direction. The only thing I care about is keeping a clear one-to-one relationship between the configuration and the command-line option: the configuration sets the default, and the command-line option overrides it.
Thanks.