Re: [PATCH v14 1/5] fetch: add remote.<name>.fetchRefmap
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2026, 15:40 UTC
- Message-ID
- <xmqq7bibh3f5.fsf@gitster.g>
- In-Reply-To
- <5a1a9f6b-48c8-4daa-9059-bf9459587a17@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> However, I think it becomes confusing if we store the ref in two > places when the user configures ".fetchRefmap" and then passes "src:dst" > on the commandline because users are used to a commandline "src:dst" > overriding the ".fetch" config, not adding to it.
True, but the src:dst on the command line in your example is still overriding the .fetch configuration. Wouldn't it make it confusing if it overrode .fetchRefmap configuration, since src:dst on the command line is what .fetch configuration gives the defaults for (and .fetchRefmap configuration gives the defaults for --refmap, not the refspec like src:dst). It may be just as confusing as if, say, a command line --refmap suddenly started overriding .fetch configuration, I am afraid.
I can buy it if the suggestion was to allow passing --no-refmap from the command line (or would --refmap="" work?) to ignore .fetchRefmap configuration, though.
Thanks.