Re: [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 7, 2015, 16:14 UTC
- Message-ID
- <xmqqegr6lgaf.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <CALKQrge3yEfmi26HMbckyw_ONRXUWtZGvz=SqqYaL2sqJaHbUg@mail.gmail.com>
Johan Herland <johan@herland.net> writes:
> Alternatively (or additionally), for issue (2), we could add a > --disable-ref-safety option to 'git notes', to explicitly disable the > safety checks for "experimental" use.
I actually would rather prefer to see a proper plumbing use supported, either by a new "git notes-plumb" subcommand or "git notes --<some option>" that gives the scriptors a stable interface to the low-level machinery without enforcing any Policy that belongs to the Porcelain layer. At the very least, the plumbing should:
- disable anything that introduces potential ambiguity, e.g. DWIMs done by expand_notes_ref(), but not limited to it.
- lift any restrictions based on policy, e.g. "where can notes trees live" (again, but not limited to this).