git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs

From
Jeff King <peff@peff.net>
Date
Jan 7, 2015, 01:19 UTC
Message-ID
<20150107011958.GA3536@peff.net>
In-Reply-To
<xmqq8uhgqkge.fsf@gitster.dls.corp.google.com>
On Tue, Jan 06, 2015 at 02:20:33AM -0800, Junio C Hamano wrote:
> The fact that "git notes merge refs/heads/master" fails is a very
> good prevention of end-user mistakes, and this removal of test
> demonstrates that we are dropping a valuable safety.
Is it really that valuable? If it were:
  git notes merge master

I could see somebody running that accidentally. But we are talking about somebody who is already fully-qualifying a ref (and anything unqualified continues to get looked up under refs/notes). Do people really go to the length of qualifying the ref and then get confused or upset that git did exactly what they asked it to do?

I'm worried that the end-user safety here is really a strawman, and we are making this more complicated than it needs to be.

-Peff
Previous: Johan HerlandNext: Junio C Hamano
Message 14 of 16 in “Accept any notes ref”
  1. 0/2 Accept any notes refKyle J. McKay, Jan 6, 2015
  2. 1/2 notes: accept any refKyle J. McKay, Jan 6, 2015
  3. 2/2 t/t3308-notes-merge.sh: succeed with relaxed notes refsKyle J. McKay, Jan 6, 2015
  4. Junio C HamanoJan 6, 2015
  5. Kyle J. McKayJan 6, 2015
  6. Junio C HamanoJan 6, 2015
  7. Kyle J. McKayJan 6, 2015
  8. Junio C HamanoJan 6, 2015
  9. Kyle J. McKayJan 7, 2015
  10. Johan HerlandJan 7, 2015
  11. Kyle J. McKayJan 7, 2015
  12. Junio C HamanoJan 7, 2015
  13. Johan HerlandJan 7, 2015
  14. Jeff KingJan 7, 2015
  15. Junio C HamanoJan 7, 2015
  16. Jeff KingJan 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.