git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 1/4] notes: don't leak memory in git_config_get_notes_strategy

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2016, 02:59 UTC
Message-ID
<xmqqegarqrnu.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160331010604.GA23999@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> On Wed, Mar 30, 2016 at 02:07:14PM -0700, Junio C Hamano wrote:
>
>> This is a tangent, but am I the only one who finds that the naming
>> of functions in config-get API is confusing?  Just wondering if we
>> should rename the ones that keeps the memory ownership to the config
>> subsystem with s/get/peek/ or something.
>
> You are definitely not the only one.
>
> I think the get/peek thing would help, but I also get confused between
> git_config_string() and git_config_get_string().

I actually do not have problems with the ones with names that do not have "get" in.

git_config_$type() is always a helper function that are designed to be called by config callback to parse (and complain) a <var, val> pair that is expected to be of $type, and git_$family_config() is always a helper function that are designed to be used as the callback of git_config() to handle the configuration related to the named command family.

Previous: Jeff KingNext: Stefan Beller
Message 7 of 20 in “[PATCHv2 0/4] Some cleanups”
  1. Stefan BellerMar 30, 2016
  2. 1/4 notes: don't leak memory in git_config_get_notes_strategyStefan Beller, Mar 30, 2016
  3. Eric SunshineMar 30, 2016
  4. Junio C HamanoMar 30, 2016
  5. Stefan BellerMar 30, 2016
  6. Jeff KingMar 31, 2016
  7. Junio C HamanoMar 31, 2016
  8. 2/4 abbrev_sha1_in_line: don't leak memoryStefan Beller, Mar 30, 2016
  9. Eric SunshineMar 30, 2016
  10. 3/4 bundle: don't leak an fd in case of early returnStefan Beller, Mar 30, 2016
  11. Jeff KingMar 30, 2016
  12. Eric SunshineMar 30, 2016
  13. Stefan BellerMar 31, 2016
  14. Philip OakleyMar 31, 2016
  15. Stefan BellerApr 1, 2016
  16. Philip OakleyApr 1, 2016
  17. 4/4 credential-cache, send_request: close fd when doneStefan Beller, Mar 30, 2016
  18. Jeff KingMar 30, 2016
  19. Stefan BellerMar 30, 2016
  20. Jeff KingMar 30, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.