[PATCHv2 0/4] Some cleanups
- From
Stefan Beller <sbeller@google.com>
- Date
- Mar 30, 2016, 17:05 UTC
- Message-ID
- <1459357518-14913-1-git-send-email-sbeller@google.com>
v2: Thanks Eric, Jeff, Junio for discussion, I picked up all hints and here is a v2.
* drop the overallocation patches (1&2) * use git_config_get_string instead of its _const equivalent, such that we don't need a cast when freeing in git_config_get_notes_strategy * Use strbuf_list_free instead of cooking our own. * have a dedicated error exit path in bundle.c, create_bundle
v1: One of my first patches to Git were cleanup patches, and I fell back to my old pattern here, while thinking on how to write better commit messages for the submodule bugfixes I currently have in flight.
Just some one liners to not leak memory or file descriptors.
They are bundled as a series, but no patch relies on any predessor.
This applies on v2.8.0.
Thanks, Stefan
Stefan Beller (4): notes: don't leak memory in git_config_get_notes_strategy abbrev_sha1_in_line: don't leak memory bundle: don't leak an fd in case of early return credential-cache, send_request: close fd when done
builtin/notes.c | 5 +++-- bundle.c | 23 +++++++++++++++++------ credential-cache.c | 1 + wt-status.c | 4 +--- 4 files changed, 22 insertions(+), 11 deletions(-)
-- 2.8.0.2.gb331331