git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 0/4] Some cleanups

From
Jeff King <peff@peff.net>
Date
Mar 30, 2016, 17:25 UTC
Message-ID
<20160330172538.GC19675@sigill.intra.peff.net>
In-Reply-To
<1459357518-14913-1-git-send-email-sbeller@google.com>
On Wed, Mar 30, 2016 at 10:05:14AM -0700, Stefan Beller wrote:
Show 9 quoted lines
> v2:
> Thanks Eric, Jeff, Junio for discussion, I picked up all hints and here
> is a v2.
> 
> * drop the overallocation patches (1&2)
> * use git_config_get_string instead of its _const equivalent, such that
>   we don't need a cast when freeing in git_config_get_notes_strategy
> * Use strbuf_list_free instead of cooking our own.
> * have a dedicated error exit path in bundle.c, create_bundle

I'm OK with all of these as-is, though I did mention a nit in the third one. I also like Junio's rewrite instead of using strbuf_list_free.

-Peff
Previous: Stefan BellerNext: Stefan Beller
Message 18 of 20 in “[PATCHv2 0/4] Some cleanups”
  1. Stefan BellerMar 30, 2016
  2. 1/4 notes: don't leak memory in git_config_get_notes_strategyStefan Beller, Mar 30, 2016
  3. Eric SunshineMar 30, 2016
  4. Junio C HamanoMar 30, 2016
  5. Stefan BellerMar 30, 2016
  6. Jeff KingMar 31, 2016
  7. Junio C HamanoMar 31, 2016
  8. 2/4 abbrev_sha1_in_line: don't leak memoryStefan Beller, Mar 30, 2016
  9. Eric SunshineMar 30, 2016
  10. 3/4 bundle: don't leak an fd in case of early returnStefan Beller, Mar 30, 2016
  11. Jeff KingMar 30, 2016
  12. Eric SunshineMar 30, 2016
  13. Stefan BellerMar 31, 2016
  14. Philip OakleyMar 31, 2016
  15. Stefan BellerApr 1, 2016
  16. Philip OakleyApr 1, 2016
  17. 4/4 credential-cache, send_request: close fd when doneStefan Beller, Mar 30, 2016
  18. Jeff KingMar 30, 2016
  19. Stefan BellerMar 30, 2016
  20. Jeff KingMar 30, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.