Re: [PATCHv2 0/4] Some cleanups

From: Jeff King <peff@peff.net>
Date: Mar 30, 2016, 17:38 UTC
Message-ID: <20160330173837.GA20706@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kYwpj+NSn4yZK0tqASQ7CghAMgE6L9thVhTwuBNmFY6PA@mail.gmail.com>

On Wed, Mar 30, 2016 at 10:32:40AM -0700, Stefan Beller wrote:

Show 10 quoted lines

> > I'm OK with all of these as-is, though I did mention a nit in the third
> > one. I also like Junio's rewrite instead of using strbuf_list_free.
> 
> I'm fine using the rewritten version instead of using strbuf_list_free. :)
> On the third one, there is one case, where we have
> 
>   if (..)
>     return error(_(text));
> 
> and that is an exit(128); eventually.

In the caller perhaps, but isn't that equivalent to:

  error(_(text));
  return -1;

I think it is OK to make assumptions about error()'s return value; that is what it is there for.

-Peff