Re: [PATCH v8 04/11] update-index: add untracked cache notifications

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2017, 17:33 UTC
Message-ID: <xmqqefxe655v.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170330032858.rdklpoipmvwjov4d@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Wed, Jan 27, 2016 at 07:58:00AM +0100, Christian Couder wrote:
>
>> diff --git a/builtin/update-index.c b/builtin/update-index.c
>> index 62222dd..369c207 100644
>> --- a/builtin/update-index.c
>> +++ b/builtin/update-index.c
>> @@ -130,7 +130,7 @@ static int test_if_untracked_cache_is_supported(void)
>>  	if (!mkdtemp(mtime_dir.buf))
>>  		die_errno("Could not make temporary directory");
>>  
>> -	fprintf(stderr, _("Testing "));
>> +	fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());
>
> Coverity points out that this is a leak (xgetcwd returns an allocated
> buffer).

I saw that quite recently and was wondering why it reported it this late. It has been in 'master' for more than a month.

In any case, thanks for noticing and I agree the fix in the other message is obviously correct.