git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 06/11] dir: add {new,add}_untracked_cache()

From
Christian Couder <christian.couder@gmail.com>
Date
Jan 27, 2016, 06:58 UTC
Message-ID
<1453877887-11586-7-git-send-email-chriscool@tuxfamily.org>
In-Reply-To
<1453877887-11586-1-git-send-email-chriscool@tuxfamily.org>

Factor out code into new_untracked_cache() and add_untracked_cache(), which will be used in later commits.

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 builtin/update-index.c | 11 +----------
 dir.c                  | 18 ++++++++++++++++++
 dir.h                  |  1 +
 3 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/builtin/update-index.c b/builtin/update-index.c
index fe7aaa3..5f8630c 100644
--- a/builtin/update-index.c
+++ b/builtin/update-index.c
@@ -1123,16 +1123,7 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
 			if (untracked_cache == UC_TEST)
 				return 0;
 		}
-		if (!the_index.untracked) {
-			struct untracked_cache *uc = xcalloc(1, sizeof(*uc));
-			strbuf_init(&uc->ident, 100);
-			uc->exclude_per_dir = ".gitignore";
-			/* should be the same flags used by git-status */
-			uc->dir_flags = DIR_SHOW_OTHER_DIRECTORIES | DIR_HIDE_EMPTY_DIRECTORIES;
-			the_index.untracked = uc;
-		}
-		add_untracked_ident(the_index.untracked);
-		the_index.cache_changed |= UNTRACKED_CHANGED;
+		add_untracked_cache(&the_index);
 		report(_("Untracked cache enabled for '%s'"), get_git_work_tree());
 	} else if (untracked_cache == UC_DISABLE) {
 		if (the_index.untracked) {
diff --git a/dir.c b/dir.c
index 29aec12..8646b18 100644
--- a/dir.c
+++ b/dir.c
@@ -1864,6 +1864,24 @@ void add_untracked_ident(struct untracked_cache *uc)
 	strbuf_addch(&uc->ident, 0);
 }
 
+static void new_untracked_cache(struct index_state *istate)
+{
+	struct untracked_cache *uc = xcalloc(1, sizeof(*uc));
+	strbuf_init(&uc->ident, 100);
+	uc->exclude_per_dir = ".gitignore";
+	/* should be the same flags used by git-status */
+	uc->dir_flags = DIR_SHOW_OTHER_DIRECTORIES | DIR_HIDE_EMPTY_DIRECTORIES;
+	istate->untracked = uc;
+}
+
+void add_untracked_cache(struct index_state *istate)
+{
+	if (!istate->untracked) {
+		new_untracked_cache(istate);
+	add_untracked_ident(istate->untracked);
+	istate->cache_changed |= UNTRACKED_CHANGED;
+}
+
 static struct untracked_cache_dir *validate_untracked_cache(struct dir_struct *dir,
 						      int base_len,
 						      const struct pathspec *pathspec)
diff --git a/dir.h b/dir.h
index 7b5855d..cfd3636 100644
--- a/dir.h
+++ b/dir.h
@@ -308,4 +308,5 @@ void free_untracked_cache(struct untracked_cache *);
 struct untracked_cache *read_untracked_extension(const void *data, unsigned long sz);
 void write_untracked_extension(struct strbuf *out, struct untracked_cache *untracked);
 void add_untracked_ident(struct untracked_cache *);
+void add_untracked_cache(struct index_state *istate);
 #endif
-- 
2.7.0.181.g07d31f8
Previous: Christian CouderNext: Christian Couder
Message 11 of 16 in “Untracked cache improvements”
  1. 00/11 Untracked cache improvementsChristian Couder, Jan 27, 2016
  2. 01/11 dir: free untracked cache when removing itChristian Couder, Jan 27, 2016
  3. 02/11 update-index: use enum for untracked cache optionsChristian Couder, Jan 27, 2016
  4. 03/11 update-index: add --test-untracked-cacheChristian Couder, Jan 27, 2016
  5. 04/11 update-index: add untracked cache notificationsChristian Couder, Jan 27, 2016
  6. Jeff KingMar 30, 2017
  7. Christian CouderMar 30, 2017
  8. Junio C HamanoMar 30, 2017
  9. Stefan BellerMar 30, 2017
  10. 05/11 update-index: move 'uc' var declarationChristian Couder, Jan 27, 2016
  11. 06/11 dir: add {new,add}_untracked_cache()Christian Couder, Jan 27, 2016
  12. 07/11 dir: add remove_untracked_cache()Christian Couder, Jan 27, 2016
  13. 08/11 dir: simplify untracked cache "ident" fieldChristian Couder, Jan 27, 2016
  14. 09/11 config: add core.untrackedCacheChristian Couder, Jan 27, 2016
  15. 10/11 test-dump-untracked-cache: don't modify the untracked cacheChristian Couder, Jan 27, 2016
  16. 11/11 t7063: add tests for core.untrackedCacheChristian Couder, Jan 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.