git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 07/11] dir: add remove_untracked_cache()

From
Christian Couder <christian.couder@gmail.com>
Date
Jan 27, 2016, 06:58 UTC
Message-ID
<1453877887-11586-8-git-send-email-chriscool@tuxfamily.org>
In-Reply-To
<1453877887-11586-1-git-send-email-chriscool@tuxfamily.org>

Factor out code into remove_untracked_cache(), which will be used in a later commit.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 builtin/update-index.c | 6 +-----
 dir.c                  | 9 +++++++++
 dir.h                  | 1 +
 3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/builtin/update-index.c b/builtin/update-index.c
index 5f8630c..d90154c 100644
--- a/builtin/update-index.c
+++ b/builtin/update-index.c
@@ -1126,11 +1126,7 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
 		add_untracked_cache(&the_index);
 		report(_("Untracked cache enabled for '%s'"), get_git_work_tree());
 	} else if (untracked_cache == UC_DISABLE) {
-		if (the_index.untracked) {
-			free_untracked_cache(the_index.untracked);
-			the_index.untracked = NULL;
-			the_index.cache_changed |= UNTRACKED_CHANGED;
-		}
+		remove_untracked_cache(&the_index);
 		report(_("Untracked cache disabled"));
 	}
 
diff --git a/dir.c b/dir.c
index 8646b18..f27b8b9 100644
--- a/dir.c
+++ b/dir.c
@@ -1882,6 +1882,15 @@ void add_untracked_cache(struct index_state *istate)
 	istate->cache_changed |= UNTRACKED_CHANGED;
 }
 
+void remove_untracked_cache(struct index_state *istate)
+{
+	if (istate->untracked) {
+		free_untracked_cache(istate->untracked);
+		istate->untracked = NULL;
+		istate->cache_changed |= UNTRACKED_CHANGED;
+	}
+}
+
 static struct untracked_cache_dir *validate_untracked_cache(struct dir_struct *dir,
 						      int base_len,
 						      const struct pathspec *pathspec)
diff --git a/dir.h b/dir.h
index cfd3636..a3dacdb 100644
--- a/dir.h
+++ b/dir.h
@@ -309,4 +309,5 @@ struct untracked_cache *read_untracked_extension(const void *data, unsigned long
 void write_untracked_extension(struct strbuf *out, struct untracked_cache *untracked);
 void add_untracked_ident(struct untracked_cache *);
 void add_untracked_cache(struct index_state *istate);
+void remove_untracked_cache(struct index_state *istate);
 #endif
-- 
2.7.0.181.g07d31f8
Previous: Christian CouderNext: Christian Couder
Message 12 of 16 in “Untracked cache improvements”
  1. 00/11 Untracked cache improvementsChristian Couder, Jan 27, 2016
  2. 01/11 dir: free untracked cache when removing itChristian Couder, Jan 27, 2016
  3. 02/11 update-index: use enum for untracked cache optionsChristian Couder, Jan 27, 2016
  4. 03/11 update-index: add --test-untracked-cacheChristian Couder, Jan 27, 2016
  5. 04/11 update-index: add untracked cache notificationsChristian Couder, Jan 27, 2016
  6. Jeff KingMar 30, 2017
  7. Christian CouderMar 30, 2017
  8. Junio C HamanoMar 30, 2017
  9. Stefan BellerMar 30, 2017
  10. 05/11 update-index: move 'uc' var declarationChristian Couder, Jan 27, 2016
  11. 06/11 dir: add {new,add}_untracked_cache()Christian Couder, Jan 27, 2016
  12. 07/11 dir: add remove_untracked_cache()Christian Couder, Jan 27, 2016
  13. 08/11 dir: simplify untracked cache "ident" fieldChristian Couder, Jan 27, 2016
  14. 09/11 config: add core.untrackedCacheChristian Couder, Jan 27, 2016
  15. 10/11 test-dump-untracked-cache: don't modify the untracked cacheChristian Couder, Jan 27, 2016
  16. 11/11 t7063: add tests for core.untrackedCacheChristian Couder, Jan 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.