Re: [PATCH v8 04/11] update-index: add untracked cache notifications

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 30, 2017, 06:24 UTC
Message-ID: <CAP8UFD1co8V++3EY7--Ubxk9G8R0909pMCCzUVggde_=MgUJzg@mail.gmail.com>
In-Reply-To: <20170330032858.rdklpoipmvwjov4d@sigill.intra.peff.net>

On Thu, Mar 30, 2017 at 5:28 AM, Jeff King <peff@peff.net> wrote:

Show 15 quoted lines

> On Wed, Jan 27, 2016 at 07:58:00AM +0100, Christian Couder wrote:
>
>> diff --git a/builtin/update-index.c b/builtin/update-index.c
>> index 62222dd..369c207 100644
>> --- a/builtin/update-index.c
>> +++ b/builtin/update-index.c
>> @@ -130,7 +130,7 @@ static int test_if_untracked_cache_is_supported(void)
>>       if (!mkdtemp(mtime_dir.buf))
>>               die_errno("Could not make temporary directory");
>>
>> -     fprintf(stderr, _("Testing "));
>> +     fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());
>
> Coverity points out that this is a leak (xgetcwd returns an allocated
> buffer).

Thanks!

http://public-inbox.org/git/20170330062208.29018-1-chriscool@tuxfamily.org/

should fix it.