Re: [PATCH v3 0/2] diff: add --stat-with-summary (was --compact-summary)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2018, 19:59 UTC
Message-ID: <xmqqefm3cgd7.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180201130221.15563-1-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 7 quoted lines

> Changes since v2 [1]:
>
> - goes back to my original version (yay!) where the extra info
>   is appended after the path name. More is described in 2/2
> - --compact-summary is now renamed --stat-with-summary and implies
>   --stat
> - 1/2 is just a cleanup patch to make it easier to add 2/2

It may be just me and other old timers, but --X-with-Y naming means quite different thing around these commands, and --stat-with-summary would hint, at least to us, that it would behave as if the two options "--stat --summary" are given at the same time.

And from that point of view, the new name is a bit confusing one.

The patches themselves look excellent.  Thanks.