Re: [PATCH v3 0/2] diff: add --stat-with-summary (was --compact-summary)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 5, 2018, 18:56 UTC
- Message-ID
- <xmqq8tc7b6yt.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CACsJy8B5DYpSQnJiLK8r4naaBh0YWLGwn9FuvM6EhP74E4E_CA@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 22 quoted lines
> On Sat, Feb 3, 2018 at 2:59 AM, Junio C Hamano <gitster@pobox.com> wrote: >> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes: >> >>> Changes since v2 [1]: >>> >>> - goes back to my original version (yay!) where the extra info >>> is appended after the path name. More is described in 2/2 >>> - --compact-summary is now renamed --stat-with-summary and implies >>> --stat >>> - 1/2 is just a cleanup patch to make it easier to add 2/2 >> >> It may be just me and other old timers, but --X-with-Y naming means >> quite different thing around these commands, and --stat-with-summary >> would hint, at least to us, that it would behave as if the two >> options "--stat --summary" are given at the same time. >> >> And from that point of view, the new name is a bit confusing one. > > I don't have any good alternative name to be honest. It's kinda hard > to come up with another word that says "extended header information > such as creations, renames and mode changes", except maybe the vague > name --stat-extended?
I actually think compact-summary was a good way to phrase it.
Personally, I think it was a UI mistake that --summary can be given independently with or without --stat (instead, there shouldn't have been the --summary option, and instead when it was added, --stat just should have gained an extra kind of output). A single option that can give both kinds of info may be a good way forward, so another possibility may be --summary-in-stat (meaning: the info given by summary is included in stat output). I dunno.