Re: [PATCH v3 0/2] diff: add --stat-with-summary (was --compact-summary)

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 5, 2018, 11:28 UTC
Message-ID: <CACsJy8B5DYpSQnJiLK8r4naaBh0YWLGwn9FuvM6EhP74E4E_CA@mail.gmail.com>
In-Reply-To: <xmqqefm3cgd7.fsf@gitster-ct.c.googlers.com>

On Sat, Feb 3, 2018 at 2:59 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> Changes since v2 [1]:
>>
>> - goes back to my original version (yay!) where the extra info
>>   is appended after the path name. More is described in 2/2
>> - --compact-summary is now renamed --stat-with-summary and implies
>>   --stat
>> - 1/2 is just a cleanup patch to make it easier to add 2/2
>
> It may be just me and other old timers, but --X-with-Y naming means
> quite different thing around these commands, and --stat-with-summary
> would hint, at least to us, that it would behave as if the two
> options "--stat --summary" are given at the same time.
>
> And from that point of view, the new name is a bit confusing one.

I don't have any good alternative name to be honest. It's kinda hard to come up with another word that says "extended header information such as creations, renames and mode changes", except maybe the vague name --stat-extended?

-- 
Duy