git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] diff: add --stat-with-summary (was --compact-summary)

From
Duy Nguyen <pclouds@gmail.com>
Date
Feb 6, 2018, 10:20 UTC
Message-ID
<CACsJy8CQLnzX6vijE+WHE3_nwqVfFiNWFb_rcA-Lw_fvGf=aFw@mail.gmail.com>
In-Reply-To
<xmqq8tc7b6yt.fsf@gitster-ct.c.googlers.com>
On Tue, Feb 6, 2018 at 1:56 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 35 quoted lines
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> On Sat, Feb 3, 2018 at 2:59 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>>>
>>>> Changes since v2 [1]:
>>>>
>>>> - goes back to my original version (yay!) where the extra info
>>>>   is appended after the path name. More is described in 2/2
>>>> - --compact-summary is now renamed --stat-with-summary and implies
>>>>   --stat
>>>> - 1/2 is just a cleanup patch to make it easier to add 2/2
>>>
>>> It may be just me and other old timers, but --X-with-Y naming means
>>> quite different thing around these commands, and --stat-with-summary
>>> would hint, at least to us, that it would behave as if the two
>>> options "--stat --summary" are given at the same time.
>>>
>>> And from that point of view, the new name is a bit confusing one.
>>
>> I don't have any good alternative name to be honest. It's kinda hard
>> to come up with another word that says "extended header information
>> such as creations, renames and mode changes", except maybe the vague
>> name --stat-extended?
>
> I actually think compact-summary was a good way to phrase it.
>
> Personally, I think it was a UI mistake that --summary can be given
> independently with or without --stat (instead, there shouldn't have
> been the --summary option, and instead when it was added, --stat
> just should have gained an extra kind of output).  A single option
> that can give both kinds of info may be a good way forward, so
> another possibility may be --summary-in-stat (meaning: the info
> given by summary is included in stat output).  I dunno.
>

+Eric maybe he has some idea (sorry I forgot to include people from the last round).

-- 
Duy
Previous: Junio C HamanoNext: Eric Sunshine
Message 7 of 19 in “diff: add --stat-with-summary (was --compact-summary)”
  1. 0/2 diff: add --stat-with-summary (was --compact-summary)Nguyễn Thái Ngọc Duy, Feb 1, 2018
  2. 1/2 diff.c: refactor pprint_rename() to use strbufNguyễn Thái Ngọc Duy, Feb 1, 2018
  3. 2/2 diff: add --stat-with-summaryNguyễn Thái Ngọc Duy, Feb 1, 2018
  4. Junio C HamanoFeb 2, 2018
  5. Duy NguyenFeb 5, 2018
  6. Junio C HamanoFeb 5, 2018
  7. Duy NguyenFeb 6, 2018
  8. Eric SunshineFeb 7, 2018
  9. Duy NguyenFeb 7, 2018
  10. Junio C HamanoFeb 7, 2018
  11. Duy NguyenFeb 10, 2018
  12. Junio C HamanoFeb 10, 2018
  13. 0/2 diff: add --compact-summary (aka nd/diff-stat-with-summary)Nguyễn Thái Ngọc Duy, Feb 24, 2018
  14. 1/2 diff.c: refactor pprint_rename() to use strbufNguyễn Thái Ngọc Duy, Feb 24, 2018
  15. 2/2 diff: add --stat-with-summaryNguyễn Thái Ngọc Duy, Feb 24, 2018
  16. 0/2 diff: add --compact-summary (aka nd/diff-stat-with-summary)Nguyễn Thái Ngọc Duy, Feb 24, 2018
  17. 1/2 diff.c: refactor pprint_rename() to use strbufNguyễn Thái Ngọc Duy, Feb 24, 2018
  18. 2/2 diff: add --compact-summaryNguyễn Thái Ngọc Duy, Feb 24, 2018
  19. Junio C HamanoFeb 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.