Re: [PATCH 1/5] coccinelle: mark the 'coccicheck' make target as .PHONY

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 23, 2018, 19:37 UTC
Message-ID: <xmqqefft68wv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180723135100.24288-2-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 5 quoted lines

> The 'coccicheck' target doesn't create a file with the same name, so
> mark it as .PHONY.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---

Good. It is customary to do so immediately before the target, not after a blank line, though.

Show 16 quoted lines

>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index e4b503d259..27bfc196dd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2685,6 +2685,8 @@ C_SOURCES = $(patsubst %.o,%.c,$(C_OBJ))
>  	fi
>  coccicheck: $(patsubst %.cocci,%.cocci.patch,$(wildcard contrib/coccinelle/*.cocci))
>  
> +.PHONY: coccicheck
> +
>  ### Installation rules
>  
>  ifneq ($(filter /%,$(firstword $(template_dir))),)