Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

From: Jeff King <peff@peff.net>
Date: Aug 3, 2018, 13:08 UTC
Message-ID: <20180803130824.GC4671@sigill.intra.peff.net>
In-Reply-To: <20180803062144.GB237521@aiede.svl.corp.google.com>

On Thu, Aug 02, 2018 at 11:21:44PM -0700, Jonathan Nieder wrote:

Show 11 quoted lines

> > diff --git a/Makefile b/Makefile
> > index d616c0412..86fdcf567 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2674,15 +2674,17 @@ COCCI_SOURCES = $(filter-out sha1collisiondetection/%,$(C_SOURCES))
> >  else
> >  COCCI_SOURCES = $(filter-out sha1dc/%,$(C_SOURCES))
> >  endif
> > +COCCI_COMBINED = contrib/coccinelle/combined.cocci
> 
> I like this approach.

I was pretty pleased with myself, too, but I had a lingering doubt about whether just cat-ing the files was legitimate. It sounds from the response elsewhere that it's not (but just happens to work now for out limited case). But it also sounds like there may be even better options.

Show 8 quoted lines

> > I guess you could even replace "COCCI_COMBINED" with "COCCI_PATCH" in
> > most of the targets, and that would let people do individual:
> > 
> >   make COCCI_PATCH=contrib/coccinelle/foo.cocci coccicheck
> 
> The issue here is that the dependencies for foo.cocci become
> unreliable, so I'd rather have a separate target for that (e.g.
> depending on FORCE) if we go that way.

Can you be more specific? I don't see how it's unreliable, unless you mean that anything relying on "coccicheck" would depend on the exact value of COCCI_PATCH.

But it may all be moot anyway, based no the responses elsewhere in the thread.

-Peff