Re: [PoC] coccinelle: make Coccinelle-related make targets more fine-grained

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 5, 2018, 23:02 UTC
Message-ID: <20180805230245.GB208811@aiede.svl.corp.google.com>
In-Reply-To: <20180803130824.GC4671@sigill.intra.peff.net>

Hi,

Jeff King wrote:

> On Thu, Aug 02, 2018 at 11:21:44PM -0700, Jonathan Nieder wrote:
>> Jeff King wrote:

Show 12 quoted lines

>>> I guess you could even replace "COCCI_COMBINED" with "COCCI_PATCH" in
>>> most of the targets, and that would let people do individual:
>>>
>>>   make COCCI_PATCH=contrib/coccinelle/foo.cocci coccicheck
>>
>> The issue here is that the dependencies for foo.cocci become
>> unreliable, so I'd rather have a separate target for that (e.g.
>> depending on FORCE) if we go that way.
>
> Can you be more specific? I don't see how it's unreliable, unless you
> mean that anything relying on "coccicheck" would depend on the exact
> value of COCCI_PATCH.

Yes, that's what I mean: changing which COCCI_PATCH to try would need to trigger re-runs.

> But it may all be moot anyway, based no the responses elsewhere in the
> thread.

Sure.

Thanks, Jonathan