Re: [PATCH 1/5] coccinelle: mark the 'coccicheck' make target as .PHONY

From: Derrick Stolee <stolee@gmail.com>
Date: Jul 23, 2018, 14:36 UTC
Message-ID: <0023a8c0-9239-d8d7-4187-922f9305449b@gmail.com>
In-Reply-To: <20180723135100.24288-2-szeder.dev@gmail.com>

On 7/23/2018 9:50 AM, SZEDER Gábor wrote:

Show 21 quoted lines

> The 'coccicheck' target doesn't create a file with the same name, so
> mark it as .PHONY.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
>   Makefile | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index e4b503d259..27bfc196dd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2685,6 +2685,8 @@ C_SOURCES = $(patsubst %.o,%.c,$(C_OBJ))
>   	fi
>   coccicheck: $(patsubst %.cocci,%.cocci.patch,$(wildcard contrib/coccinelle/*.cocci))
>   
> +.PHONY: coccicheck
> +
>   ### Installation rules
>   
>   ifneq ($(filter /%,$(firstword $(template_dir))),)

I did not know about phony targets [1] so thanks for teaching me something today.

[1] https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html